api/server/router/grpc: NewRouter: set correct MaxRecvMsgSize, MaxSendMsgSize

thaJeztah · thaJeztah · commit cdbfae1d3eb6 · 2024-07-26T11:15:46.000+02:00
[buildkit@29b4b1a537][1] applied changes to `buildkitd` to set the correct defaults, which should be 16MB, but used the library defaults. Without that change, builds using large Dockerfiles would fail with a `ResourceExhausted` error; => [internal] load build definition from Dockerfile => => transferring dockerfile: 896.44kB ERROR: failed to receive status: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (44865299 vs. 16777216) However those changes were applied to the `buildkitd` code, which is the daemon when running BuildKit standalone (or in a container through the `container` driver). When running a build with the BuildKit builder compiled into the Docker Engine, that code is not used, so the BuildKit changes did not fix the issue. This patch applies the same changes as were made in [buildkit@29b4b1a537][1] to the gRPC endpoint provided by the dockerd daemon. [1]: moby/buildkit@29b4b1a Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
diff --git a/api/server/router/grpc/grpc.go b/api/server/router/grpc/grpc.go
@@ -9,6 +9,7 @@ import (
 	"os"
 	"strings"
 
+	"github.com/containerd/containerd/defaults"
 	"github.com/containerd/log"
 	"github.com/docker/docker/api/server/router"
 	"github.com/moby/buildkit/util/grpcerrors"
@@ -32,6 +33,8 @@ func NewRouter(backends ...Backend) router.Router {
 		grpc.StatsHandler(tracing.ServerStatsHandler(otelgrpc.WithTracerProvider(otel.GetTracerProvider()))),
 		grpc.ChainUnaryInterceptor(unaryInterceptor, grpcerrors.UnaryServerInterceptor),
 		grpc.StreamInterceptor(grpcerrors.StreamServerInterceptor),
+		grpc.MaxRecvMsgSize(defaults.DefaultMaxRecvMsgSize),
+		grpc.MaxSendMsgSize(defaults.DefaultMaxSendMsgSize),
 	}
 
 	r := &grpcRouter{
