internal/opts: SetOpts: invalidate empty option-names

thaJeztah · thaJeztah · commit c2fc1f4a409c · 2024-09-16T11:00:06.000+02:00
Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
diff --git a/internal/opts/opts.go b/internal/opts/opts.go
@@ -1,6 +1,7 @@
 package opts
 
 import (
+	"errors"
 	"fmt"
 	"strconv"
 	"strings"
@@ -17,6 +18,9 @@ type SetOpts struct {
 // internal map, by splitting on '='.
 func (opts *SetOpts) Set(value string) error {
 	k, v, found := strings.Cut(value, "=")
+	if k == "" {
+		return errors.New("invalid option name: " + value)
+	}
 	var isSet bool
 	if !found {
 		isSet = true
diff --git a/internal/opts/opts_test.go b/internal/opts/opts_test.go
@@ -24,6 +24,10 @@ func TestSetOpts(t *testing.T) {
 
 	err := o.Set("feature=not-a-bool")
 	assert.Check(t, is.Error(err, `strconv.ParseBool: parsing "not-a-bool": invalid syntax`))
+	err = o.Set("feature=")
+	assert.Check(t, is.Error(err, `strconv.ParseBool: parsing "": invalid syntax`))
+	err = o.Set("=true")
+	assert.Check(t, is.Error(err, `invalid option name: =true`))
 }
 
 func TestNamedSetOpts(t *testing.T) {
@@ -45,4 +49,8 @@ func TestNamedSetOpts(t *testing.T) {
 
 	err := o.Set("feature=not-a-bool")
 	assert.Check(t, is.Error(err, `strconv.ParseBool: parsing "not-a-bool": invalid syntax`))
+	err = o.Set("feature=")
+	assert.Check(t, is.Error(err, `strconv.ParseBool: parsing "": invalid syntax`))
+	err = o.Set("=true")
+	assert.Check(t, is.Error(err, `invalid option name: =true`))
 }
