Fix isGitURL regular expression

whalelines · whalelines · commit 768146b1b067 · 2024-01-18T14:14:08.000-06:00
Escape period (.) so regular expression does not match any character before "git".

Signed-off-by: David Dooling &lt;david.dooling@docker.com&gt;
diff --git a/builder/remotecontext/urlutil/urlutil.go b/builder/remotecontext/urlutil/urlutil.go
@@ -12,7 +12,7 @@ import (
 
 // urlPathWithFragmentSuffix matches fragments to use as Git reference and build
 // context from the Git repository. See IsGitURL for details.
-var urlPathWithFragmentSuffix = regexp.MustCompile(".git(?:#.+)?$")
+var urlPathWithFragmentSuffix = regexp.MustCompile(`\.git(?:#.+)?$`)
 
 // IsURL returns true if the provided str is an HTTP(S) URL by checking if it
 // has a http:// or https:// scheme. No validation is performed to verify if the
diff --git a/builder/remotecontext/urlutil/urlutil_test.go b/builder/remotecontext/urlutil/urlutil_test.go
@@ -17,6 +17,7 @@ var (
 	}
 	invalidGitUrls = []string{
 		"http://github.com/docker/docker.git:#branch",
+		"https://github.com/docker/dgit",
 	}
 )
 

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,7 @@ var (`
`17`	`17`	`}`
`18`	`18`	`invalidGitUrls = []string{`
`19`	`19`	`"http://github.com/docker/docker.git:#branch",`
	`20`	`+ "https://github.com/docker/dgit",`
`20`	`21`	`}`
`21`	`22`	`)`
`22`	`23`