Migrates docker info tests to integration api tests

yongtang · yongtang · commit 68d9beedbe09 · 2018-02-07T18:26:01.000Z
This fix migrates docker info tests in integration-cli
to integration tests.

Signed-off-by: Yong Tang &lt;yong.tang.github@outlook.com&gt;
diff --git a/integration-cli/docker_api_info_test.go b/integration-cli/docker_api_info_test.go
diff --git a/integration/system/info_linux_test.go b/integration/system/info_linux_test.go
@@ -3,15 +3,17 @@
 package system
 
 import (
+	"net/http"
 	"testing"
 
+	req "github.com/docker/docker/integration-cli/request"
 	"github.com/docker/docker/integration/util/request"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 	"golang.org/x/net/context"
 )
 
-func TestInfo_BinaryCommits(t *testing.T) {
+func TestInfoBinaryCommits(t *testing.T) {
 	client := request.NewAPIClient(t)
 
 	info, err := client.Info(context.Background())
@@ -32,3 +34,18 @@ func TestInfo_BinaryCommits(t *testing.T) {
 	assert.Equal(t, testEnv.DaemonInfo.RuncCommit.Expected, info.RuncCommit.Expected)
 	assert.Equal(t, info.RuncCommit.Expected, info.RuncCommit.ID)
 }
+
+func TestInfoAPIVersioned(t *testing.T) {
+	// Windows only supports 1.25 or later
+
+	res, body, err := req.Get("/v1.20/info")
+	require.NoError(t, err)
+	assert.Equal(t, res.StatusCode, http.StatusOK)
+
+	b, err := req.ReadBody(body)
+	require.NoError(t, err)
+
+	out := string(b)
+	assert.Contains(t, out, "ExecutionDriver")
+	assert.Contains(t, out, "not supported")
+}
diff --git a/integration/system/info_test.go b/integration/system/info_test.go
@@ -0,0 +1,42 @@
+package system
+
+import (
+	"fmt"
+	"testing"
+
+	"github.com/docker/docker/integration/util/request"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+	"golang.org/x/net/context"
+)
+
+func TestInfoAPI(t *testing.T) {
+	client := request.NewAPIClient(t)
+
+	info, err := client.Info(context.Background())
+	require.NoError(t, err)
+
+	// always shown fields
+	stringsToCheck := []string{
+		"ID",
+		"Containers",
+		"ContainersRunning",
+		"ContainersPaused",
+		"ContainersStopped",
+		"Images",
+		"LoggingDriver",
+		"OperatingSystem",
+		"NCPU",
+		"OSType",
+		"Architecture",
+		"MemTotal",
+		"KernelVersion",
+		"Driver",
+		"ServerVersion",
+		"SecurityOptions"}
+
+	out := fmt.Sprintf("%+v", info)
+	for _, linePrefix := range stringsToCheck {
+		assert.Contains(t, out, linePrefix)
+	}
+}
