pkg/parsers: deprecate ParseUintListMaximum, ParseUintList

thaJeztah · thaJeztah · commit 064cdf475c83 · 2025-01-06T21:12:36.000+01:00
These utilities have been moved internal to pkg/sysinfo in 2282279, and are no longer used. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
diff --git a/pkg/parsers/parsers.go b/pkg/parsers/parsers.go
@@ -34,6 +34,8 @@ func ParseKeyValueOpt(opt string) (key string, value string, err error) {
 //	03,1-3      <- this is gonna get parsed as [1,2,3]
 //	3,2,1
 //	0-2,3,1
+//
+// Deprecated: ParseUintListMaximum was only used internally and will be removed in the next release.
 func ParseUintListMaximum(val string, maximum int) (map[int]bool, error) {
 	return parseUintList(val, maximum)
 }
@@ -52,6 +54,8 @@ func ParseUintListMaximum(val string, maximum int) (map[int]bool, error) {
 //	03,1-3      <- this is gonna get parsed as [1,2,3]
 //	3,2,1
 //	0-2,3,1
+//
+// Deprecated: ParseUintList was only used internally and will be removed in the next release.
 func ParseUintList(val string) (map[int]bool, error) {
 	return parseUintList(val, 0)
 }
diff --git a/pkg/parsers/parsers_test.go b/pkg/parsers/parsers_test.go
@@ -45,7 +45,7 @@ func TestParseUintList(t *testing.T) {
 		"0-2,3,1":      {0: true, 1: true, 2: true, 3: true},
 	}
 	for k, v := range valids {
-		out, err := ParseUintList(k)
+		out, err := parseUintList(k, 0)
 		if err != nil {
 			t.Fatalf("Expected not to fail, got %v", err)
 		}
@@ -63,21 +63,21 @@ func TestParseUintList(t *testing.T) {
 		"-1,0",
 	}
 	for _, v := range invalids {
-		if out, err := ParseUintList(v); err == nil {
+		if out, err := parseUintList(v, 0); err == nil {
 			t.Fatalf("Expected failure with %s but got %v", v, out)
 		}
 	}
 }
 
 func TestParseUintListMaximumLimits(t *testing.T) {
 	v := "10,1000"
-	if _, err := ParseUintListMaximum(v, 0); err != nil {
+	if _, err := parseUintList(v, 0); err != nil {
 		t.Fatalf("Expected not to fail, got %v", err)
 	}
-	if _, err := ParseUintListMaximum(v, 1000); err != nil {
+	if _, err := parseUintList(v, 1000); err != nil {
 		t.Fatalf("Expected not to fail, got %v", err)
 	}
-	if out, err := ParseUintListMaximum(v, 100); err == nil {
+	if out, err := parseUintList(v, 100); err == nil {
 		t.Fatalf("Expected failure with %s but got %v", v, out)
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ func TestParseUintList(t *testing.T) {`
`45`	`45`	`"0-2,3,1": {0: true, 1: true, 2: true, 3: true},`
`46`	`46`	`}`
`47`	`47`	`for k, v := range valids {`
`48`		`- out, err := ParseUintList(k)`
	`48`	`+ out, err := parseUintList(k, 0)`
`49`	`49`	`if err != nil {`
`50`	`50`	`t.Fatalf("Expected not to fail, got %v", err)`
`51`	`51`	`}`
`@@ -63,21 +63,21 @@ func TestParseUintList(t *testing.T) {`
`63`	`63`	`"-1,0",`
`64`	`64`	`}`
`65`	`65`	`for _, v := range invalids {`
`66`		`- if out, err := ParseUintList(v); err == nil {`
	`66`	`+ if out, err := parseUintList(v, 0); err == nil {`
`67`	`67`	`t.Fatalf("Expected failure with %s but got %v", v, out)`
`68`	`68`	`}`
`69`	`69`	`}`
`70`	`70`	`}`
`71`	`71`
`72`	`72`	`func TestParseUintListMaximumLimits(t *testing.T) {`
`73`	`73`	`v := "10,1000"`
`74`		`- if _, err := ParseUintListMaximum(v, 0); err != nil {`
	`74`	`+ if _, err := parseUintList(v, 0); err != nil {`
`75`	`75`	`t.Fatalf("Expected not to fail, got %v", err)`
`76`	`76`	`}`
`77`		`- if _, err := ParseUintListMaximum(v, 1000); err != nil {`
	`77`	`+ if _, err := parseUintList(v, 1000); err != nil {`
`78`	`78`	`t.Fatalf("Expected not to fail, got %v", err)`
`79`	`79`	`}`
`80`		`- if out, err := ParseUintListMaximum(v, 100); err == nil {`
	`80`	`+ if out, err := parseUintList(v, 100); err == nil {`
`81`	`81`	`t.Fatalf("Expected failure with %s but got %v", v, out)`
`82`	`82`	`}`
`83`	`83`	`}`