containerd-shim-runc-v2: remove unnecessary s.getContainer()

cyyzero · cyyzero · commit 6604ff6c55a5 · 2023-10-02T17:44:41.000Z
Previous code has already called `getContainer()`, just pass it into
`s.getContainerPids` to reduce unnecessary lock and map lookup.

Signed-off-by: Chen Yiyang &lt;cyyzero@qq.com&gt;
diff --git a/runtime/v2/runc/task/service.go b/runtime/v2/runc/task/service.go
@@ -462,7 +462,7 @@ func (s *service) Pids(ctx context.Context, r *taskAPI.PidsRequest) (*taskAPI.Pi
 	if err != nil {
 		return nil, err
 	}
-	pids, err := s.getContainerPids(ctx, r.ID)
+	pids, err := s.getContainerPids(ctx, container)
 	if err != nil {
 		return nil, errdefs.ToGRPC(err)
 	}
@@ -664,16 +664,12 @@ func (s *service) handleProcessExit(e runcC.Exit, c *runc.Container, p process.P
 	})
 }
 
-func (s *service) getContainerPids(ctx context.Context, id string) ([]uint32, error) {
-	container, err := s.getContainer(id)
-	if err != nil {
-		return nil, err
-	}
+func (s *service) getContainerPids(ctx context.Context, container *runc.Container) ([]uint32, error) {
 	p, err := container.Process("")
 	if err != nil {
 		return nil, errdefs.ToGRPC(err)
 	}
-	ps, err := p.(*process.Init).Runtime().Ps(ctx, id)
+	ps, err := p.(*process.Init).Runtime().Ps(ctx, container.ID)
 	if err != nil {
 		return nil, err
 	}

Original file line number	Diff line number	Diff line change
`@@ -462,7 +462,7 @@ func (s service) Pids(ctx context.Context, r taskAPI.PidsRequest) (*taskAPI.Pi`
`462`	`462`	`if err != nil {`
`463`	`463`	`return nil, err`
`464`	`464`	`}`
`465`		`- pids, err := s.getContainerPids(ctx, r.ID)`
	`465`	`+ pids, err := s.getContainerPids(ctx, container)`
`466`	`466`	`if err != nil {`
`467`	`467`	`return nil, errdefs.ToGRPC(err)`
`468`	`468`	`}`
`@@ -664,16 +664,12 @@ func (s service) handleProcessExit(e runcC.Exit, c runc.Container, p process.P`
`664`	`664`	`})`
`665`	`665`	`}`
`666`	`666`
`667`		`-func (s *service) getContainerPids(ctx context.Context, id string) ([]uint32, error) {`
`668`		`- container, err := s.getContainer(id)`
`669`		`- if err != nil {`
`670`		`- return nil, err`
`671`		`- }`
	`667`	`+func (s service) getContainerPids(ctx context.Context, container runc.Container) ([]uint32, error) {`
`672`	`668`	`p, err := container.Process("")`
`673`	`669`	`if err != nil {`
`674`	`670`	`return nil, errdefs.ToGRPC(err)`
`675`	`671`	`}`
`676`		`- ps, err := p.(*process.Init).Runtime().Ps(ctx, id)`
	`672`	`+ ps, err := p.(*process.Init).Runtime().Ps(ctx, container.ID)`
`677`	`673`	`if err != nil {`
`678`	`674`	`return nil, err`
`679`	`675`	`}`