Fix slice append error

liubin · liubin · commit 0c63c42f8183 · 2022-11-12T00:22:04.000+08:00
In golang when copy a slice, if the slice is initialized with a
desired length, then appending to it will cause the size double.

Signed-off-by: bin liu &lt;liubin0329@gmail.com&gt;
diff --git a/pkg/cri/server/helpers.go b/pkg/cri/server/helpers.go
@@ -474,7 +474,7 @@ func copyResourcesToStatus(spec *runtimespec.Spec, status containerstore.Status)
 		}
 
 		if spec.Linux.Resources.HugepageLimits != nil {
-			hugepageLimits := make([]*runtime.HugepageLimit, len(spec.Linux.Resources.HugepageLimits))
+			hugepageLimits := make([]*runtime.HugepageLimit, 0)
 			for _, l := range spec.Linux.Resources.HugepageLimits {
 				hugepageLimits = append(hugepageLimits, &runtime.HugepageLimit{
 					PageSize: l.Pagesize,
diff --git a/pkg/cri/store/container/status.go b/pkg/cri/store/container/status.go
@@ -219,7 +219,7 @@ func deepCopyOf(s Status) Status {
 	}
 	copy.Resources = &runtime.ContainerResources{}
 	if s.Resources != nil && s.Resources.Linux != nil {
-		hugepageLimits := make([]*runtime.HugepageLimit, len(s.Resources.Linux.HugepageLimits))
+		hugepageLimits := make([]*runtime.HugepageLimit, 0)
 		for _, l := range s.Resources.Linux.HugepageLimits {
 			hugepageLimits = append(hugepageLimits, &runtime.HugepageLimit{
 				PageSize: l.PageSize,

Original file line number	Diff line number	Diff line change
`@@ -474,7 +474,7 @@ func copyResourcesToStatus(spec *runtimespec.Spec, status containerstore.Status)`
`474`	`474`	`}`
`475`	`475`
`476`	`476`	`if spec.Linux.Resources.HugepageLimits != nil {`
`477`		`- hugepageLimits := make([]*runtime.HugepageLimit, len(spec.Linux.Resources.HugepageLimits))`
	`477`	`+ hugepageLimits := make([]*runtime.HugepageLimit, 0)`
`478`	`478`	`for _, l := range spec.Linux.Resources.HugepageLimits {`
`479`	`479`	`hugepageLimits = append(hugepageLimits, &runtime.HugepageLimit{`
`480`	`480`	`PageSize: l.Pagesize,`
Original file line number	Diff line number	Diff line change
`@@ -219,7 +219,7 @@ func deepCopyOf(s Status) Status {`
`219`	`219`	`}`
`220`	`220`	`copy.Resources = &runtime.ContainerResources{}`
`221`	`221`	`if s.Resources != nil && s.Resources.Linux != nil {`
`222`		`- hugepageLimits := make([]*runtime.HugepageLimit, len(s.Resources.Linux.HugepageLimits))`
	`222`	`+ hugepageLimits := make([]*runtime.HugepageLimit, 0)`
`223`	`223`	`for _, l := range s.Resources.Linux.HugepageLimits {`
`224`	`224`	`hugepageLimits = append(hugepageLimits, &runtime.HugepageLimit{`
`225`	`225`	`PageSize: l.PageSize,`