Merged
Conversation
ShooterIT
commented
Oct 15, 2025
| mh->asm_import_input_buffer = asmGetImportInputBufferSize(); | ||
| mh->asm_migrate_output_buffer = asmGetMigrateOutputBufferSize(); | ||
| mem_total += mh->asm_import_input_buffer; | ||
| mem_total += mh->asm_migrate_output_buffer; |
Collaborator
Author
There was a problem hiding this comment.
we should update mem_total here, otherwise, we will miss updating mh->overhead_total
ShooterIT
commented
Oct 15, 2025
src/server.c
Outdated
| @@ -6053,6 +6053,7 @@ sds genRedisInfoString(dict *section_dict, int all_sections, int everything) { | |||
| "mem_replica_full_sync_buffer:%zu\r\n", server.repl_full_sync_buffer.mem_used, | |||
| "mem_asm_migrate_output_buffer:%zu\r\n", mh->asm_migrate_output_buffer, | |||
| "mem_asm_import_input_buffer:%zu\r\n", mh->asm_import_input_buffer, | |||
| "mem_slot_migration_sync_buffer_peak:%zu\r\n", asmGetPeakSyncBufferSize(), | |||
Collaborator
Author
There was a problem hiding this comment.
maybe mem_asm_migrate_output_buffer and mem_asm_import_input_buffer should be change to
mem_slot_migration_output_buffer and mem_slot_migration_input_buffer?
Owner
There was a problem hiding this comment.
I'm happy that I felt the same way and made the exact change without seeing this :)
ShooterIT
commented
Oct 15, 2025
| @@ -840,34 +840,24 @@ start_cluster 3 3 {tags {external:skip cluster} overrides {cluster-node-timeout | |||
| } | |||
|
|
|||
| test "Flush-like command can cancel slot migration task" { | |||
| # we set a delay to cancel | |||
Collaborator
Author
There was a problem hiding this comment.
just find it is not stable
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## cluster-asm #103 +/- ##
==============================================
Coverage ? 76.01%
==============================================
Files ? 131
Lines ? 76247
Branches ? 0
==============================================
Hits ? 57958
Misses ? 18289
Partials ? 0
🚀 New features to boost your workflow:
|
tezc
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.