chore: migrate from eslint to oxlint (#1992)

azu · claude · web-flow · commit 08a9cdc89811 · 2026-04-08T23:28:40.000+09:00
## Summary

Migrates the repository's linter from ESLint to oxlint for faster
linting. Replaces `eslint.config.js` with `.oxlintrc.json` and updates
related scripts and dependencies.

## Changes

- Add `.oxlintrc.json` with the project's lint rules
- Remove `eslint.config.js`
- Update `package.json` scripts and dependencies to use oxlint
- Drop the `minimatch` override
- Fix lint violations surfaced by oxlint in a few source and test files
- Update `pnpm-workspace.yaml` and `pnpm-lock.yaml`

## Breaking Changes

None.

## Test Plan

- [ ] `pnpm -r run lint` passes
- [ ] `pnpm -r run test` passes
- [ ] CI is green

---------

Co-authored-by: Claude &lt;noreply@anthropic.com&gt;
diff --git a/.oxlintrc.json b/.oxlintrc.json
@@ -0,0 +1,67 @@
+{
+  "$schema": "./node_modules/oxlint/configuration_schema.json",
+  "plugins": [
+    "typescript"
+  ],
+  "categories": {
+    "correctness": "error"
+  },
+  "rules": {
+    "no-console": "warn",
+    "no-var": "error",
+    "prefer-const": "error",
+    "prefer-rest-params": "error",
+    "prefer-spread": "error",
+    "prefer-template": "error",
+    "no-unused-vars": "off",
+    "typescript/no-require-imports": "off",
+    "typescript/no-explicit-any": "error",
+    "typescript/no-empty-object-type": "error",
+    "typescript/ban-ts-comment": "error",
+    "typescript/no-unsafe-function-type": "error",
+    "typescript/unbound-method": "off",
+    "typescript/restrict-template-expressions": "off",
+    "typescript/no-redundant-type-constituents": "off"
+  },
+  "overrides": [
+    {
+      "files": ["**/*.ts"],
+      "rules": {
+        "typescript/no-require-imports": "error"
+      }
+    },
+    {
+      "files": [
+        "**/bin/**",
+        "**/scripts/**",
+        "examples/**",
+        "**/debug-*.{js,mjs,ts}",
+        "**/tools/**",
+        "**/*.test.ts"
+      ],
+      "rules": {
+        "no-console": "off"
+      }
+    }
+  ],
+  "ignorePatterns": [
+    "**/lib/**",
+    "**/module/**",
+    "out/",
+    "node_modules/**",
+    "packages/textlint-scripts/examples/",
+    "test/integration-test/",
+    "website/",
+    "dist/**",
+    "build/**",
+    "coverage/**",
+    "*.min.js"
+  ],
+  "env": {
+    "browser": true,
+    "node": true,
+    "es2022": true,
+    "mocha": true,
+    "builtin": true
+  }
+}
diff --git a/eslint.config.js b/eslint.config.js
diff --git a/package.json b/package.json
@@ -9,11 +9,9 @@
     "ci:versionup:patch": "lerna version patch --no-push --no-git-tag-version --yes && pnpm run commit-version",
     "clean": "pnpm -r run clean",
     "commit-version": "git add . && git commit -m \"chore(release): v`node -p 'require(\"./lerna.json\").version'`\"",
-    "eslint": "eslint --cache \"packages/**/{src,test}/**/*.{js,ts}\"",
-    "eslint:fix": "eslint --fix --cache \"packages/**/{src,test}/**/*.{js,ts}\"",
     "format": "prettier --write \"**/*.{js,jsx,ts,tsx,css}\"",
-    "lint": "npm-run-all eslint",
-    "lint:fix": "npm-run-all eslint:fix",
+    "lint": "oxlint --type-aware",
+    "lint:fix": "oxlint --type-aware --fix",
     "perf": "cd ./examples/perf && pnpm run test:ci",
     "prepare": "git config --local core.hooksPath .githooks",
     "release": "lerna publish from-package",
@@ -42,19 +40,15 @@
     "trailingComma": "none"
   },
   "devDependencies": {
-    "@eslint/js": "catalog:",
     "@lerna-lite/cli": "catalog:",
     "@lerna-lite/publish": "catalog:",
     "@lerna-lite/version": "catalog:",
     "@monorepo-utils/workspaces-to-typescript-project-references": "catalog:",
-    "@typescript-eslint/eslint-plugin": "catalog:",
-    "@typescript-eslint/parser": "catalog:",
     "ajv": "catalog:",
-    "eslint": "catalog:",
-    "eslint-config-prettier": "catalog:",
-    "globals": "catalog:",
     "lint-staged": "catalog:",
     "npm-run-all2": "catalog:",
+    "oxlint": "catalog:",
+    "oxlint-tsgolint": "catalog:",
     "prettier": "catalog:",
     "typescript": "catalog:",
     "vitest": "catalog:"
diff --git a/packages/@textlint/fixer-formatter/test/formatters/compats.test.ts b/packages/@textlint/fixer-formatter/test/formatters/compats.test.ts
@@ -13,7 +13,7 @@ import remainingFixture from "../fixtures/remaining.js";
 // Helper function to normalize paths to just filenames for cross-platform compatibility
 const normalizePaths = (output: string) => {
     // Replace any path ending with a filename and replace with just the filename
-    return output.replace(/[^\s]*[\/\\]([^\/\\]+\.md)/g, "$1");
+    return output.replace(/[^\s]*[/\\]([^/\\]+\.md)/g, "$1");
 };
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
diff --git a/packages/@textlint/fixer-formatter/test/formatters/diff.test.ts b/packages/@textlint/fixer-formatter/test/formatters/diff.test.ts
@@ -14,7 +14,7 @@ import remainingFixture from "../fixtures/remaining.js";
 // Helper function to normalize paths to just filenames for cross-platform compatibility
 const normalizePaths = (output: string) => {
     // Replace any path ending with a filename and replace with just the filename
-    return output.replace(/[^\s]*[\/\\]([^\/\\]+\.md)/g, "$1");
+    return output.replace(/[^\s]*[/\\]([^/\\]+\.md)/g, "$1");
 };
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
diff --git a/packages/@textlint/kernel/src/core/source-location.ts b/packages/@textlint/kernel/src/core/source-location.ts
@@ -30,7 +30,7 @@ export type SourceLocationPaddingIR =
 
 const assertReportArgs = (reportArgs: Pick<TextlintRuleContextReportFunctionArgs, "node" | "ruleError" | "ruleId">) => {
     const { ruleError, ruleId } = reportArgs;
-    const errorPrefix = `[${ruleId}]` || "";
+    const errorPrefix = `[${ruleId}]`;
     const padding = ruleError;
 
     /*
diff --git a/packages/@textlint/kernel/src/descriptor/TextlintPluginDescriptor.ts b/packages/@textlint/kernel/src/descriptor/TextlintPluginDescriptor.ts
@@ -22,7 +22,7 @@ const getAvailableExtensions = (pluginProcessor: TextlintPluginProcessor): strin
     if (typeof PluginProcessorConstructor.availableExtensions === "function") {
         return PluginProcessorConstructor.availableExtensions();
     }
-    throw new Error(`Plugin(${pluginProcessor}) should implement availableExtensions() method`);
+    throw new Error(`Plugin(${pluginProcessor.constructor.name}) should implement availableExtensions() method`);
 };
 
 /**
@@ -32,7 +32,6 @@ export class TextlintPluginDescriptor implements Descriptor<TextlintKernelPlugin
     public processor: TextlintPluginProcessor;
 
     constructor(private plugin: TextlintKernelPlugin) {
-        this.plugin = plugin;
         if (!this.plugin.plugin.Processor) {
             throw new Error(`Plugin should have Processor property.
 module.exports = {
diff --git a/packages/@textlint/kernel/src/task/promise-event-emitter.ts b/packages/@textlint/kernel/src/task/promise-event-emitter.ts
@@ -66,10 +66,10 @@ export class PromiseEventEmitter {
     }
 
     emit(event: string, ...args: unknown[]): Promise<void[]> {
-        const promises: (Promise<void> | void)[] = [];
+        const promises: Promise<void>[] = [];
 
         this.events.listeners(event).forEach((listener) => {
-            promises.push(listener(...args));
+            promises.push(Promise.resolve(listener(...args)));
         });
 
         return Promise.all(promises);
diff --git a/packages/textlint/src/cli.ts b/packages/textlint/src/cli.ts
@@ -90,7 +90,7 @@ export const cli = {
 
             const mcpServer = await connectStdioMcpServer(mcpOptions);
             process.on("SIGINT", () => {
-                mcpServer.close();
+                void mcpServer.close();
                 process.exitCode = 0;
             });
             return 0;
diff --git a/packages/textlint/test/mcp-snapshot-test/snapshot-utils.ts b/packages/textlint/test/mcp-snapshot-test/snapshot-utils.ts
@@ -141,7 +141,7 @@ function normalizeStructuredPaths(obj: unknown, snapshotDir: string, testCaseNam
                     }
                 } else if (normalizedPath.includes("snapshots")) {
                     // Fallback: extract from path structure
-                    const parts = normalizedPath.split(/[\/\\]/);
+                    const parts = normalizedPath.split(/[/\\]/);
                     const snapshotIndex = parts.findIndex((part) => part === "snapshots");
                     if (snapshotIndex >= 0 && snapshotIndex < parts.length - 2) {
                         const caseName = parts[snapshotIndex + 1];
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml

Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ function normalizeStructuredPaths(obj: unknown, snapshotDir: string, testCaseNam`
`141`	`141`	`}`
`142`	`142`	`} else if (normalizedPath.includes("snapshots")) {`
`143`	`143`	`// Fallback: extract from path structure`
`144`		`- const parts = normalizedPath.split(/[\/\\]/);`
	`144`	`+ const parts = normalizedPath.split(/[/\\]/);`
`145`	`145`	`const snapshotIndex = parts.findIndex((part) => part === "snapshots");`
`146`	`146`	`if (snapshotIndex >= 0 && snapshotIndex < parts.length - 2) {`
`147`	`147`	`const caseName = parts[snapshotIndex + 1];`