fix issues with units in the Quick Start wizard (Geometry tab)#3157
Merged
sunderme merged 3 commits intotexstudio-org:masterfrom Jun 12, 2023
Merged
fix issues with units in the Quick Start wizard (Geometry tab)#3157sunderme merged 3 commits intotexstudio-org:masterfrom
sunderme merged 3 commits intotexstudio-org:masterfrom
Conversation
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances the page geometry configuration that is part of the Quick Start wizard.
Note: This PR is a cut down of #3156. A detailed discussion can be found there.
The PR addresses following observations:
Lengths are given with a number combined with a unit. This unit is also mirrored as a suffix to the number in the spin box. When you alter a unit then the number is not adjusted (s. image below). This means that the length changes. But the picture visualizing the settings doesn't change (workaround: change temp. the number with up/down buttons). This is fixed.
The mirrored units are removed by the PR (s. Test below).
Fig,: Visualization doesn't reflect change of width when altering unit in combo box. Unit is editable (s. cursor mark).
You can enter unknown units (like pico meters pm or nano meters nm) or even any text. In this case dialog falls back to mm. Unit dm is not in the list of the combo boxes, but is recognized when you enter it manually. But dm is not known to LaTeX. The PR therefore sets attribute editable to false for those combo boxes. As side effects signal
editTextChanged()is replaced bycurrentTextChanged()and the names for the unit combo boxes are corrected fromspinBoxUnitGeometryPageWidthtocomboBoxUnitGeometryPageWidth, and so on.Code setting checkBoxes without effect is removed. Update: Since not totally correct this part is reverted.
Test
Fig.: Visualization now reflects change of width when altering unit in combo box (not editable). Suffix units are not present.
These values are correctly saved in and loaded from the ini file. The LaTeX code looks fine: