rectangular magnifier with shadow#2889
Merged
sunderme merged 1 commit intotexstudio-org:masterfrom Jan 27, 2023
octaeder:magnifierShadow
Merged
rectangular magnifier with shadow#2889sunderme merged 1 commit intotexstudio-org:masterfrom octaeder:magnifierShadow
sunderme merged 1 commit intotexstudio-org:masterfrom
octaeder:magnifierShadow
Conversation
sunderme
reviewed
Jan 27, 2023
| } | ||
|
|
||
| void PDFDraggableTool::drawCircleGradient(QPainter& painter, const QRect& outline, QColor color, int padding) | ||
| void PDFDraggableTool::drawGradient(QPainter& painter, const QRect& outline, QColor color, int padding, int magnifierShape) |
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #2885. By this the configuration of the magnifier's shape, border, and shadow are fully separated by providing a checkbox for the shadow. In addition the user can select the shape of a rectangle (formerly called square) with a shadow:
Backward compatibility
Default is Circle with shadow as before. Old values are mapped like this:
First case is exceptional because a shadow is added. But this is a very, very small change of the GUI. All other cases make no change.
On the other hand: A combobox with item Rectangle with shadow appended would give a random item sequence, and anyone would ask, "border is not part of the list, so why is shadow?"