Skip to content

Comments

#995 using frameGeometry to calculate available space for configDialog.#2868

Merged
sunderme merged 3 commits intotexstudio-org:masterfrom
gaplin:#995-open-close-buttons-not-visible-on-config-dialog
Jan 22, 2023
Merged

#995 using frameGeometry to calculate available space for configDialog.#2868
sunderme merged 3 commits intotexstudio-org:masterfrom
gaplin:#995-open-close-buttons-not-visible-on-config-dialog

Conversation

@gaplin
Copy link
Contributor

@gaplin gaplin commented Jan 22, 2023

Using frameGeometry to calculate difference between size of the dialog with and without frame to get rid of 32 constant.
Doing this only for vertical part since only that one is affected.

Modified solution from qt forum post.

This PR resolves #995.

@octaeder
Copy link
Contributor

octaeder commented Jan 22, 2023

@gaplin When you edit your description of this PR and add following sentence then this PR is linked to issue #995. Thus merging this PR will automatically close the issue. This will be stated to the right of this page.

This PR solves #995.

@gaplin
Copy link
Contributor Author

gaplin commented Jan 22, 2023

"Solves" didn't work, resolves did.

@sunderme sunderme merged commit 6f6d3c8 into texstudio-org:master Jan 22, 2023
@octaeder
Copy link
Contributor

"Solves" didn't work, resolves did.

You are right, sorry. All possibilities can be found here. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

On win10 the save and cancel buttons are not visible.

3 participants