wasi: adds platform.Dirent in preparation of inode fetching #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasi_snapshot_preview1 recently requires fd_readdir to return actual inode values. On zero, wasi-libc will call fdstat to retrieve them. This introduces our own `platform.Dirent` type and `Readdir` function which a later change will allow fetching of inodes. See WebAssembly/wasi-libc#345 Signed-off-by: Adrian Cole <[email protected]>
evacchi
approved these changes
Feb 23, 2023
Signed-off-by: Adrian Cole <[email protected]>
|
thanks for the look @evacchi even though this is internal, we should look more carefully as we near to 1.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasi_snapshot_preview1 recently requires fd_readdir to return actual inode values. On zero, wasi-libc will call fdstat to retrieve them.
This introduces our own
platform.Direnttype andReaddirfunction which a later change will allow fetching of inodes.See WebAssembly/wasi-libc#345