fix: work around shadowed globals#892
Merged
ph-fritsche merged 2 commits intomainfrom Mar 31, 2022
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 983b930:
|
Codecov Report
@@ Coverage Diff @@
## main #892 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 84 85 +1
Lines 1758 1774 +16
Branches 656 657 +1
=========================================
+ Hits 1758 1774 +16
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 14.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Remove direct references to global constructors for DOM(-related) implementation.
Why:
Codesandbox environment has shadowed global constructors which break
instanceofchecks.See codesandbox/codesandbox-client#6580
How:
Get the
windowfrom the elements/document.Get the constructor from that
window.Checklist: