fix(pointer): consider click context#850
Merged
ph-fritsche merged 1 commit intobetafrom Feb 8, 2022
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d3ce526:
|
Codecov Report
@@ Coverage Diff @@
## beta #850 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 89 89
Lines 1762 1763 +1
Branches 622 623 +1
=========================================
+ Hits 1762 1763 +1
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 14.0.0-beta.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Consider the ancestor elements when applying
clickbehavior.Why:
If a click happens inside a
<button>,<input>,<label>or<textarea>element, this changes the default behavior.Extending the code snippet that focused the associated control of a clicked label to also apply the click on the control
resulted in a loop if the control was nested inside that label.
Closes #848
Closes #849
How:
user-event/src/event/behavior/click.ts
Lines 6 to 8 in d3ce526
Checklist: