fix(upload): fix order of events#847
Merged
ph-fritsche merged 3 commits intobetafrom Feb 7, 2022
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ab1361e:
|
Codecov Report
@@ Coverage Diff @@
## beta #847 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 85 89 +4
Lines 1736 1762 +26
Branches 619 622 +3
=========================================
+ Hits 1736 1762 +26
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 14.0.0-beta.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Feb 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Replace default behavior as part of the central event dispatching.
Why:
The order of events for
userEvent.uploadwas incorrect.When clicking the
<input type="file"/>element in the browser:mousedownblurevent on the element.inputandchangeevent.focusevent on the element.Event handlers on the
clickevent can prevent opening the file dialog in the browser.The previous implementation did not honor
Event.defaultPrevented.How:
Implement default behavior as plugins to the central
dispatchUIEventintroduced in #838 .If a default behavior is implemented by this library, the default behavior implemented by the DOM implementation is disabled per
event.preventDefault().Then
event.defaultPreventedandevent.preventDefault()are replaced so that event handlers can use them as usual.Checklist: