fix(pointer): blur activeElement on click outside of focusable#834
Merged
ph-fritsche merged 1 commit intobetafrom Jan 16, 2022
Merged
fix(pointer): blur activeElement on click outside of focusable#834ph-fritsche merged 1 commit intobetafrom
activeElement on click outside of focusable#834ph-fritsche merged 1 commit intobetafrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e74defe:
|
Codecov Report
@@ Coverage Diff @@
## beta #834 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 81 81
Lines 1701 1705 +4
Branches 611 618 +7
=========================================
+ Hits 1701 1705 +4
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 14.0.0-beta.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Focus
document.bodyonmousedownoutside of focusable.Why:
Closes #832
user-event/src/pointer/pointerPress.ts
Lines 277 to 279 in e74defe
When the mousedown happens (or would have happened) outside of a focusable context,
the focus is moved to
document.body.How:
Blur
activeElementwhenfocushelper is called with an element outside of focusable context.Checklist: