feat: dispatch FocusEvent in hidden documents#1252
Merged
ph-fritsche merged 3 commits intomainfrom Jan 15, 2025
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
ph-fritsche
force-pushed
the
fix-focus
branch
from
941cb0f to
049e5f9
Compare
|
🎉 This PR is included in version 14.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 tasks
3 tasks
|
It looks like this change broke some integrations. See #1258. For me it broke react-aria here:
I have to stick with 14.5.2 for now. |
Merged
4 tasks
alanbsmith
pushed a commit
to Workday/canvas-kit
that referenced
this pull request
Feb 24, 2025
…#3147) Update `useComboboxInputConstrained` to use reconfiguration vs rewrite for `focus`/`blur` method redirection. This fixes an issue with `user-event` that overwrites these methods to not be rewritable: testing-library/user-event#1252 The extra syntax makes things feel a little more enterprise Java. [category:Components]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Dispatch
focus,focusin,blurandfocusoutevents whendocument.visibilityStateishidden.Why:
Browsers don't dispatch focus events on hidden windows.
Our simulation of the UI layer relies on these events and userEvent should act like a user does on a visible window.
How:
Patch
HTMLElement.focus()andHTMLElement.blur()and dispatch the events if the document is hidden.Checklist: