chore: do not build in pre-commit#1008
Merged
ph-fritsche merged 3 commits intomainfrom Aug 1, 2022
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit af4d677:
|
ph-fritsche
force-pushed
the
chore-validate
branch
from
c859f80 to
af4d677
Compare
Codecov Report
@@ Coverage Diff @@
## main #1008 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 87 87
Lines 1876 1876
Branches 679 679
=========================================
Hits 1876 1876 Help us with your feedback. Take ten seconds to tell us how you rate us. |
|
🎉 This PR is included in version 14.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Run
typecheckduring pre-commit.Run
linttestandbuildin CI.Why:
buildwrites to the file system includingpackage.jsonwhich might result in uncommitted changes.The properties set on
package.jsonby the build script should not be included in the repository as this might give the false impression that changes there might have an effect on the distributed package.How:
During
pre-commithook thevalidatescript skipslintandtestand only runsbuildandtypecheck.We only need
typecheckhere.In CI the
validatescript runslint,test,buildandtypecheck.The build already includes the typecheck.
=> The
validatescript invoked by thepre-commitscript directly callskcd-scripts typecheck.=> The CI explicitly lists
lint,testandbuildas separate steps.Checklist: