fix: prevent click event loop on form-associated custom element (#1238)

hesxenon · Katja Potensky · ph-fritsche · web-flow · commit 465fc7eb49d3 · 2025-01-21T18:30:56.000+01:00
Co-authored-by: Katja Potensky &lt;785327-hesxenon@users.noreply.gitlab.com&gt;
Co-authored-by: Philipp Fritsche &lt;ph.fritsche@gmail.com&gt;
diff --git a/src/event/behavior/click.ts b/src/event/behavior/click.ts
@@ -5,7 +5,7 @@ import {behavior} from './registry'
 behavior.click = (event, target, instance) => {
   const context = target.closest('button,input,label,select,textarea')
   const control = context && isElementType(context, 'label') && context.control
-  if (control) {
+  if (control && control !== target) {
     return () => {
       if (isFocusable(control)) {
         focusElement(control)
diff --git a/tests/pointer/click.ts b/tests/pointer/click.ts
@@ -1,4 +1,4 @@
-import {setup} from '#testHelpers'
+import {isJsdomEnv, setup} from '#testHelpers'
 
 test('click element', async () => {
   const {element, getClickEventsSnapshot, getEvents, user} = setup('<div />')
@@ -236,6 +236,29 @@ describe('label', () => {
     expect(getEvents('click')).toHaveLength(2)
   })
 
+  test('click nested FACE per label', async () => {
+    const {element, getEvents, user} = setup(`<label><fa-ce></fa-ce></label>`)
+
+    await user.pointer({
+      keys: '[MouseLeft]',
+      target: element,
+    })
+
+    // JSDOM does not set `HTMLLabelElement.control` to the form-associated custom element
+    expect(getEvents('click')).toHaveLength(isJsdomEnv() ? 1 : 2)
+  })
+
+  test('click nested FACE', async () => {
+    const {element, getEvents, user} = setup(`<label><fa-ce></fa-ce></label>`)
+
+    await user.pointer({
+      keys: '[MouseLeft]',
+      target: element.firstChild as Element,
+    })
+
+    expect(getEvents('click')).toHaveLength(1)
+  })
+
   test('do not click associated non-focusable control per label', async () => {
     const {element, getEvents, user} = setup(
       `<label for="in">foo</label><input disabled id="in"/>`,
@@ -404,3 +427,10 @@ test('preventDefault on pointer down prevents compatibility events works with po
   `)
   expect(getEvents('click')).toHaveLength(1)
 })
+
+customElements.define(
+  'fa-ce',
+  class FaCe extends globalThis.window.HTMLElement {
+    static formAssociated = true
+  },
+)
