Skip to content

Add docs for ByRole 'level' option#582

Merged
kentcdodds merged 2 commits into
testing-library:masterfrom
winterlamon:pr/add-level-option-to-byrole-heading
Aug 27, 2020
Merged

Add docs for ByRole 'level' option#582
kentcdodds merged 2 commits into
testing-library:masterfrom
winterlamon:pr/add-level-option-to-byrole-heading

Conversation

@winterlamon

Copy link
Copy Markdown
Contributor

Adds documentation for the level option on the ByRole query introduced in testing-library/dom-testing-library#757

getByRole('heading', { level: number })

@eps1lon eps1lon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Everything accounted for 👍

Comment thread docs/dom-testing-library/api-queries.md Outdated

@kentcdodds kentcdodds left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stellar work here 👍

@kentcdodds
kentcdodds merged commit e5c907f into testing-library:master Aug 27, 2020
@kentcdodds

Copy link
Copy Markdown
Member

@all-contributors please add @winterlamon for docs

@allcontributors

Copy link
Copy Markdown
Contributor

@kentcdodds

I've put up a pull request to add @winterlamon! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants