[WIP] Bring typings from DefinitelyTyped into this repo#690
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b0d9a33:
|
| @@ -0,0 +1,59 @@ | |||
| // TypeScript Version: 3.8 | |||
There was a problem hiding this comment.
Bumped this from 3.1 to 3.8 for this support:
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-and-exports
|
Looks awesome. I don't know about the dtslint stuff, but once that's worked out I'm good to merge 👍 Thanks! |
Add `pure.d.ts` that re-exports everything from `index.d.ts` Turn off `whitespace` rule
Codecov Report
@@ Coverage Diff @@
## master #690 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 99 99
Branches 15 15
=========================================
Hits 99 99 Continue to review full report at Codecov.
|
|
@all-contributors please add @samtsai for code and tests |
|
I've put up a pull request to add @samtsai! 🎉 |
|
🎉 This PR is included in version 10.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the |
2 participants
What:
Improve support of typings by bringing them into this repo instead of relying on a versioned external repo
Why:
Help with stability for consumers using typings and give a clearer understanding of what should be supported in a given version without having to reference multiple repos.
How:
Modeled after these changes in a sibling repo: testing-library/dom-testing-library#530
Checklist:
docs site
Currently this does not validate with several errors for [email protected], example:
I'm still investigating this, but if anyone knows more about
dtslintI'm all 👂