test: Run with relevant React stable types#1352
Merged
eps1lon merged 1 commit intotesting-library:mainfrom Mar 17, 2025
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d955710:
|
eps1lon
force-pushed
the
type-test-matrix
branch
2 times, most recently
from
7a954f1 to
88abd93
Compare
Dustin4444
approved these changes
Mar 12, 2025
MatanBobi
approved these changes
Mar 12, 2025
This has no effect right now. Once React 19 is out, we're running tests in both 18 and 19. The types should match that dimension. Ideally, we'd be able to test RC types but npm claims `npm install @types/react@npm:types-react@rc` is an invalid comparator. Putting that in the package.json works but I'm too lazy to write a dedicated script right now.
eps1lon
force-pushed
the
type-test-matrix
branch
from
747305e to
d955710
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has no effect right now since
latestand18.xpoint at the same version.Once React 19 is out, we'll be running tests in both 18 and 19.
The types should match that dimension.
Ideally, we'd be able to test RC types but npm claims
npm install @types/react@npm:types-react@rcis an invalid comparator.Putting that in the package.json works but I'm too lazy to write a dedicated script right now.