fix: improve warning so people know they can upgrade to 16.9.0 now (#431)

Kent C. Dodds · web-flow · commit c0266503bfff · 2019-08-08T16:54:48.000-06:00
Closes #281
diff --git a/package.json b/package.json
@@ -41,17 +41,17 @@
   "author": "Kent C. Dodds <kent@doddsfamily.us> (http://kentcdodds.com/)",
   "license": "MIT",
   "dependencies": {
-    "@babel/runtime": "^7.5.4",
-    "@testing-library/dom": "^5.5.4"
+    "@babel/runtime": "^7.5.5",
+    "@testing-library/dom": "^5.6.1"
   },
   "devDependencies": {
     "@reach/router": "^1.2.1",
     "@testing-library/jest-dom": "^4.0.0",
-    "@types/react": "^16.8.23",
-    "@types/react-dom": "^16.8.4",
+    "@types/react": "^16.8.25",
+    "@types/react-dom": "^16.8.5",
     "kcd-scripts": "^1.5.2",
-    "react": "^16.8.6",
-    "react-dom": "^16.8.6"
+    "react": "^16.9.0",
+    "react-dom": "^16.9.0"
   },
   "peerDependencies": {
     "react": "*",
diff --git a/src/__tests__/old-act.js b/src/__tests__/old-act.js
@@ -10,10 +10,6 @@ afterEach(() => {
   console.error.mockRestore()
 })
 
-jest.mock('../react-dom-16.9.0-is-released', () => ({
-  reactDomSixteenPointNineIsReleased: true,
-}))
-
 jest.mock('react-dom/test-utils', () => ({
   act: cb => {
     cb()
diff --git a/src/act-compat.js b/src/act-compat.js
@@ -1,7 +1,6 @@
 import React from 'react'
 import ReactDOM from 'react-dom'
 import * as testUtils from 'react-dom/test-utils'
-import {reactDomSixteenPointNineIsReleased} from './react-dom-16.9.0-is-released'
 
 const reactAct = testUtils.act
 const actSupported = reactAct !== undefined
@@ -28,6 +27,7 @@ function asyncAct(cb) {
         const originalConsoleError = console.error
         console.error = function error(...args) {
           /* if console.error fired *with that specific message* */
+          /* istanbul ignore next */
           if (
             args[0].indexOf(
               'Warning: Do not await the result of calling ReactTestUtils.act',
@@ -75,8 +75,8 @@ function asyncAct(cb) {
 
         if (isAsyncActSupported === false) {
           console.error = originalConsoleError
-          /* istanbul-ignore-next */
-          if (!youHaveBeenWarned && reactDomSixteenPointNineIsReleased) {
+          /* istanbul ignore next */
+          if (!youHaveBeenWarned) {
             // if act is supported and async act isn't and they're trying to use async
             // act, then they need to upgrade from 16.8 to 16.9.
             // This is a seemless upgrade, so we'll add a warning
diff --git a/src/react-dom-16.9.0-is-released.js b/src/react-dom-16.9.0-is-released.js
