fix(suggestions): don't suggest byLabelText when using byLabelText#835
Merged
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 53f29f7:
|
Codecov Report
@@ Coverage Diff @@
## master #835 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 934 934
Branches 286 286
=========================================
Hits 934 934
Continue to review full report at Codecov.
|
Member
Author
|
@testing-library/dom 👋 |
nickserv
approved these changes
Nov 20, 2020
|
🎉 This PR is included in version 7.28.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: a bug fix on suggestions for findByLabelText
Why: when using findByLabelText, you would get a suggestion even if you're already using findByLabelText.
How: use the right function when passing the name of the method.
Checklist:
docs site