fix: use node property instead of selector for type=text input#823
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 79b8b0a:
|
172aa5b to
686492c
Compare
Codecov Report
@@ Coverage Diff @@
## master #823 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 910 922 +12
Branches 276 281 +5
=========================================
+ Hits 910 922 +12
Continue to review full report at Codecov.
|
|
p.s. from this build I'm having an issue on commit, script hangs on test. EDIT: it is regarding to this issue EDIT2: fixed reinstalling everything |
kentcdodds
left a comment
kentcdodds
left a comment
There was a problem hiding this comment.
Looks good to me 👍 Anyone else want to weigh in?
eps1lon
left a comment
eps1lon
left a comment
There was a problem hiding this comment.
Works for now. I'll revisit this in aria-query though or rather with a more holistic approach. Either aria-query always means "check the property not the attribute" or aria-query needs to be explicit when you check attributes vs. when you check properties.
|
@eps1lon should we just wait for aria-query instead? Or do you think that's further down the road? |
Future improvement. This PR is good to go. |
|
🎉 This PR is included in version 7.26.7 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
3 participants
What: close #814
Why: It was a bug
How: Adding an exception for type=text.
Instead of using the selector I have used the node property.
Checklist:
docs site