Skip to content

fix: export pretty format#818

Merged
kentcdodds merged 2 commits into
testing-library:masterfrom
marcosvega91:pr/export_pretty_format
Nov 10, 2020
Merged

fix: export pretty format#818
kentcdodds merged 2 commits into
testing-library:masterfrom
marcosvega91:pr/export_pretty_format

Conversation

@marcosvega91

@marcosvega91 marcosvega91 commented Nov 10, 2020

Copy link
Copy Markdown
Member

What: referring to this issue testing-library/react-testing-library#694 I have exported pretty-format from this library

Why: Because we can then import in @testing-library/react

How:

Checklist:

  • Documentation added to the
    docs site
  • Tests
  • Typescript definitions updated
  • Ready to be merged

@codesandbox-ci

codesandbox-ci Bot commented Nov 10, 2020

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 27dc128:

Sandbox Source
react-testing-library-examples Configuration

@codecov

codecov Bot commented Nov 10, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #818 (27dc128) into master (2fea70c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #818   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          910       910           
  Branches       276       276           
=========================================
  Hits           910       910
Impacted Files Coverage Δ
src/pretty-dom.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fea70c...27dc128. Read the comment docs.

@nickserv
nickserv requested a review from kentcdodds November 10, 2020 16:10
kentcdodds
kentcdodds approved these changes Nov 10, 2020
View reviewed changes

@kentcdodds kentcdodds left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a reasonable solution to the problem (to make sure everyone's using the correct version of prettyFormat and it's typings). Thank you!

@kentcdodds
kentcdodds merged commit e32937c into testing-library:master Nov 10, 2020
@github-actions

github-actions Bot commented Nov 10, 2020

Copy link
Copy Markdown

🎉 This PR is included in version 7.26.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@marcosvega91
marcosvega91 deleted the pr/export_pretty_format branch November 10, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickserv nickserv nickserv approved these changes
@kentcdodds kentcdodds kentcdodds approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marcosvega91 @nickserv @kentcdodds