Skip to content

docs: link directly to dom docs#816

Merged
kentcdodds merged 1 commit into
masterfrom
nickmccurdy-patch-1
Nov 9, 2020
Merged

docs: link directly to dom docs#816
kentcdodds merged 1 commit into
masterfrom
nickmccurdy-patch-1

Conversation

@nickserv

@nickserv nickserv commented Nov 9, 2020

Copy link
Copy Markdown
Member

What:

We should link to /dom not /

@codesandbox-ci

codesandbox-ci Bot commented Nov 9, 2020

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0a31b1b:

Sandbox Source
react-testing-library-examples Configuration

@MatanBobi

Copy link
Copy Markdown
Member

LGTM and the failures aren't related and looks like they started after the move to github actions..
I think we can merge this.

@kentcdodds kentcdodds left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I think @MichaelDeBoey mentioned the failures are related to a breakage in typescript

@kentcdodds
kentcdodds merged commit c9917a3 into master Nov 9, 2020
@kentcdodds
kentcdodds deleted the nickmccurdy-patch-1 branch November 9, 2020 14:03
@kentcdodds

kentcdodds commented Nov 9, 2020

Copy link
Copy Markdown
Member

This is what's busted:

$ npm ls @types/estree
@testing-library/[email protected] /Users/kentcdodds/code/dom-testing-library
└─┬ [email protected]
  ├─┬ @rollup/[email protected]
  │ └─┬ @rollup/[email protected]
  │   └── @types/[email protected] 
  ├─┬ @rollup/[email protected]
  │ └─┬ [email protected]
  │   └── @types/[email protected]  deduped
  └─┬ [email protected]
    └─┬ [email protected]
      ├─┬ @types/[email protected]
      │ ├─┬ @types/[email protected]
      │ │ └── @types/[email protected]  deduped
      │ └── @types/[email protected]  deduped
      └── @types/[email protected] 

We have mis-matched versions of estree in kcd-scripts. I'm working on this today.

@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 7.26.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants