refactor: export label helpers to his own file and use both in suggestions and query#790
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 08d619a:
|
Codecov Report
@@ Coverage Diff @@
## master #790 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 26 +1
Lines 724 719 -5
Branches 190 184 -6
=========================================
- Hits 724 719 -5
Continue to review full report at Codecov.
|
kentcdodds
left a comment
kentcdodds
left a comment
There was a problem hiding this comment.
Looks pretty good. Just one thing.
kentcdodds
left a comment
kentcdodds
left a comment
There was a problem hiding this comment.
Ok, I think it looks good to me. I'd love another reviewer here though. @delca85?
I will be happy to review it but I am going to look at it in a couple of hours, ok? |
|
Is not a problem |
|
I approved this one. I think using the same logic in both suggestion and get labels logic is really a good idea! As well as fixing the suggestion defect related to label concatenation, for sure. |
|
Looks like @marcosvega91's other PR made a conflict with this one. Could you get that fixed @marcosvega91? Thanks! |
a407ff1 to
5c74abf
Compare
|
I have rebased the branch 👍 :) |
5c74abf to
08d619a
Compare
|
🎉 This PR is included in version 7.26.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
4 participants
What: Moved label helpers to his own file
Why: suggestions was using his logic to get label content that was not working with
aria-labelledbyHow: Using the logic implemented by @delca85 both for suggestions and label query
Checklist:
docs site