feat: add logPlaygroundUrl in screen#781
Conversation
|
Do let me know what you think of this. This mostly PRd version of what @smeijer had suggested. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d773f84:
|
marcosvega91
left a comment
marcosvega91
left a comment
There was a problem hiding this comment.
Hi @balavishnuvj thanks for this implementation 💯 . I have added some comments
|
Hi @marcosvega91 , thank you reviewing so quick. Have addressed your concerns :) |
Codecov Report
@@ Coverage Diff @@
## master #781 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 703 725 +22
Branches 183 188 +5
=========================================
+ Hits 703 725 +22
Continue to review full report at Codecov.
|
kentcdodds
left a comment
kentcdodds
left a comment
There was a problem hiding this comment.
This is super! 👏 Just one little thing that I can merge myself. Thank you :)
5a110de
kentcdodds
left a comment
kentcdodds
left a comment
There was a problem hiding this comment.
@marcosvega91 reminded me that we should do TS updates on this PR. You up for that @balavishnuvj?
…ting-library into feat/playground-url
|
@kentcdodds I have tried to update the types. All the |
|
🎉 This PR is included in version 7.26.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
@all-contributors please add @balavishnuvj for code |
|
I've put up a pull request to add @balavishnuvj! 🎉 |
4 participants
Based on discussion at #780