fix: element error delegation#777
Merged
kentcdodds merged 1 commit intoOct 6, 2020
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit db2115e:
|
Codecov Report
@@ Coverage Diff @@
## master #777 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 702 703 +1
Branches 183 183
=========================================
+ Hits 702 703 +1
Continue to review full report at Codecov.
|
alexkrolick
approved these changes
Oct 6, 2020
Member
|
@all-contributors please add @Tismas for code and tests |
Contributor
|
I've put up a pull request to add @Tismas! 🎉 |
|
🎉 This PR is included in version 7.24.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Using
getElementErrorfrom configuration inwaitForandsingleQuriesso that user can customize error reporting consistently.Why: Currently when configuring getElementError it works differently in for example
getByTextvswaitFor(() => getByText).How: Instead of calling prettyDOM directly I changed it so that it uses
getElementErrorfrom configuration.Checklist:
docs site