Skip to content

fix: Mark deprecated methods as @deprecated#771

Merged
eps1lon merged 1 commit into
testing-library:masterfrom
Semigradsky:typescript
Sep 25, 2020
Merged

fix: Mark deprecated methods as @deprecated#771
eps1lon merged 1 commit into
testing-library:masterfrom
Semigradsky:typescript

Conversation

@Semigradsky

Copy link
Copy Markdown
Contributor

For warning TS users early.

How it looks in 'VS Code':

image

@codesandbox-ci

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 101542f:

Sandbox Source
kentcdodds/react-testing-library-examples Configuration

@codecov

codecov Bot commented Sep 25, 2020

Copy link
Copy Markdown

Codecov Report

Merging #771 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #771   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines          702       702           
  Branches       183       183           
=========================================
  Hits           702       702           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3154dc4...101542f. Read the comment docs.

@eps1lon eps1lon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super helpful, thanks!

@eps1lon eps1lon changed the title Add deprecation messages to d.ts files fix: Mark deprecated methods as @deprecated Sep 25, 2020
@eps1lon
eps1lon merged commit 68f8f81 into testing-library:master Sep 25, 2020
@eps1lon

eps1lon commented Sep 25, 2020

Copy link
Copy Markdown
Member

@all-contributors add @Semigradsky for code

@allcontributors

Copy link
Copy Markdown
Contributor

@eps1lon

I've put up a pull request to add @Semigradsky! 🎉

@testing-library-bot

Copy link
Copy Markdown

🎉 This PR is included in version 7.24.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants