feat: add allowed roles to role query types#670
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9fc4f91:
|
Codecov Report
@@ Coverage Diff @@
## master #670 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 603 603
Branches 151 151
=========================================
Hits 603 603 Continue to review full report at Codecov.
|
951b539 to
ed48005
Compare
eps1lon
left a comment
eps1lon
left a comment
There was a problem hiding this comment.
Looks good. One minor question though.
dc77621 to
bce30bf
Compare
|
Seems legit. Looks like travis is failing due to some linting issues in the types? |
|
You're right @kentcdodds . |
| "no-relative-import-in-test": false, | ||
| "semicolon": false | ||
| "semicolon": false, | ||
| "whitespace": false |
There was a problem hiding this comment.
Disabled whitespace checks because this clashes with our prettier configuration.
|
Should be good to go on my end, can you have another look at it @eps1lon and share your thoughts? |
|
@timdeschryver Nice work! |
|
🎉 This PR is included in version 7.20.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
3 participants
What:
Why:
How:
Checklist:
docs site
@eps1lon is there already a aria roles union type available that could be reused?