fix: Treat header as banner role #656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest [aria-query version](https://github.com/A11yance/aria-query/releases/tag/v4.2.2) fixes the issue of failing to recognize `<header>` as a `banner` role. Fixes: testing-library#578
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c6e1bb9:
|
Codecov Report
@@ Coverage Diff @@
## master #656 +/- ##
===========================================
- Coverage 100.00% 99.65% -0.35%
===========================================
Files 24 24
Lines 582 582
Branches 149 149
===========================================
- Hits 582 580 -2
- Misses 0 2 +2
Continue to review full report at Codecov.
|
Member
|
@all-contributors please add @darekkay for code and tests |
Contributor
|
I've put up a pull request to add @darekkay! 🎉 |
Member
|
🎉 This PR is included in version 7.16.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
<header>is not recognized asbannerrole, and cannot be selected withgetByRole("banner").See also: #578
Why:
It should work correctly according to the specs.
How:
Update
aria-querydependency. The latest aria-query version fixes the issue of failing to recognize<header>as abannerrole.Checklist:
docs site N/A
Fixes: #578