Skip to content

fix: Bump dom-accessibility-api#606

Merged
kentcdodds merged 1 commit into
testing-library:masterfrom
eps1lon:fix/bump-daa
Jun 5, 2020
Merged

fix: Bump dom-accessibility-api#606
kentcdodds merged 1 commit into
testing-library:masterfrom
eps1lon:fix/bump-daa

Conversation

@eps1lon

@eps1lon eps1lon commented Jun 5, 2020

Copy link
Copy Markdown
Member

What:

Closes #591

Why:

Use implemented behavior of browsers over spec

How:

Bump dom-accessibility-api

Checklist:

  • [ ] Documentation added to the
    docs site
  • [ ] I've prepared a PR for types targeting
    DefinitelyTyped
  • Tests Verify with codesandbox of linked issue
  • Ready to be merged

@eps1lon eps1lon added the bug Something isn't working label Jun 5, 2020
@codesandbox-ci

codesandbox-ci Bot commented Jun 5, 2020

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d8ce091:

Sandbox Source
cool-lalande-hc72c Configuration
react-testing-library demo Issue #591

@codecov

codecov Bot commented Jun 5, 2020

Copy link
Copy Markdown

Codecov Report

Merging #606 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #606   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          550       550           
  Branches       137       137           
=========================================
  Hits           550       550           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4f6da7...d8ce091. Read the comment docs.

@kentcdodds
kentcdodds merged commit fb012de into testing-library:master Jun 5, 2020
@kentcdodds

Copy link
Copy Markdown
Member

Thanks! 👏

@kentcdodds

Copy link
Copy Markdown
Member

Just made you an admin on the repo so you can merge PRs like this without having to wait for me :)

@kentcdodds

Copy link
Copy Markdown
Member

🎉 This PR is included in version 7.10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@eps1lon
eps1lon deleted the fix/bump-daa branch June 5, 2020 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extra space added around embedded expressions in JSX when querying by role + name

2 participants