Add methods to get and check host address to Container#139
Closed
amarsinghcodes wants to merge 13 commits intotestcontainers:masterfrom
Closed
Add methods to get and check host address to Container#139amarsinghcodes wants to merge 13 commits intotestcontainers:masterfrom
amarsinghcodes wants to merge 13 commits intotestcontainers:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I received direction from @bsideup but this PR is still a work-in-progress. I've bumped the versions and added the
urlcrate as a dependency to parse the key for theDOCKER_HOSTprocess (seeContainer::set_host).why
The point is to add
set_hostsuch that theContainerobject is initialized with a new field corresponding to the host address.Without this logic, there is no guarantee that the host address is not
localhost, and its neglect can lead to careless mistakes that may compromise security.The reason the
hostfield is added to theContainerobject is to save future lookups (acting like a cache).