Repository navigation
Added docker host detection and support for setting container host explicitly with env variable - #85
Conversation
tillahoffmann
left a comment
There was a problem hiding this comment.
Thank you for this, @tuvshuud! One small follow up question.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #85 +/- ##
==========================================
- Coverage 84.94% 79.95% -5.00%
==========================================
Files 19 19
Lines 392 434 +42
Branches 25 34 +9
==========================================
+ Hits 333 347 +14
- Misses 43 68 +25
- Partials 16 19 +3 ☔ View full report in Codecov by Sentry. |
|
I have looked into failed test cases. They are required fix in this PR. I think they are used to fail in the docker:dind before. I will push some more commits to fix these when I have some time in the next week. |
|
@tillahoffmann I have fixed the test cases and improved host detection function. Also, I ran all the test cases on Gitlab CI/CD and all passed. Can you merge into gitlab2 and check it now? |
Changes:
Fix to #81, #74, #43