Skip to content

Update dependency management, python version constraints, extended tests, docker-in-docker - #66

Merged
tillahoffmann merged 3 commits into
testcontainers:masterfrom
tillahoffmann:tests
Feb 20, 2020
Merged

Update dependency management, python version constraints, extended tests, docker-in-docker#66
tillahoffmann merged 3 commits into
testcontainers:masterfrom
tillahoffmann:tests

Conversation

@tillahoffmann

@tillahoffmann tillahoffmann commented Feb 20, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Drop pipenv and use requirements for each version.
    • pipenv is a great initiative, but pip-tools is still faster, more mature, more reliable, and more stable.
    • Adds docker images for minor python versions from 3.5 to 3.8 and a Makefile to generate requirements as well as run tests locally for different python versions.
  • Update python versions, unpin selenium.
    • selenium was pinned to a particular version which might make it difficult to install the extension if requirements conflict.
    • Add python 3.5 as minimum requirement as 3.4 is EOL.
  • Adjust tests for docker in docker.
    • Some of the tests assumed that code had to be run on the host directly.

Closes #63.

@codecov-io

codecov-io commented Feb 20, 2020

Copy link
Copy Markdown

Codecov Report

Merging #66 into master will increase coverage by 0.31%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   82.92%   83.24%   +0.31%     
==========================================
  Files          19       19              
  Lines         369      376       +7     
  Branches       23       23              
==========================================
+ Hits          306      313       +7     
  Misses         48       48              
  Partials       15       15
Impacted Files Coverage Δ
testcontainers/compose.py 100% <100%> (ø) ⬆️
testcontainers/core/generic.py 100% <0%> (ø) ⬆️
testcontainers/elasticsearch.py 91.66% <0%> (+0.36%) ⬆️
testcontainers/selenium.py 89.28% <0%> (+0.39%) ⬆️
testcontainers/core/waiting_utils.py 91.42% <0%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e7db7d...c24f9a7. Read the comment docs.

@tillahoffmann
tillahoffmann merged commit 30433d2 into testcontainers:master Feb 20, 2020
This was referenced Apr 28, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tillahoffmann @codecov-io