Skip to content

Require python >= 3.4 - #63

Closed
martykube wants to merge 2 commits into
testcontainers:masterfrom
martykube:master
Closed

martykube wants to merge 2 commits into
testcontainers:masterfrom
martykube:master

Conversation

@martykube

Copy link
Copy Markdown

This will enforce minimum python version during installation.

You have to have up-to-date versions of pip and setuptools for this to be enforced: https://python3statement.org/practicalities/

@martykube

Copy link
Copy Markdown
Author

Resolves #20

@codecov-io

codecov-io commented Feb 18, 2020 •

Copy link
Copy Markdown

Codecov Report

Merging #63 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   84.65%   84.65%           
=======================================
  Files          18       18           
  Lines         352      352           
  Branches       20       20           
=======================================
  Hits          298      298           
  Misses         38       38           
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f97070...50d89eb. Read the comment docs.

@martykube

Copy link
Copy Markdown
Author

To enforce python3 we need to use recent build tools when preparing the distribution.

This change makes sure we have pip>=9.0 and setuptools >=24.2.0 for 'pipenv install --dev'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants