Repository navigation
Support specifying postgresql drivers - #156
Merged
Merged
Conversation
Contributor
Author
|
Btw, I wasn't able to quickly google the docstring format. Would you please point me to the spec so I could format the docstring properly? https://github.com/testcontainers/testcontainers-python/pull/156/files#diff-0d0163aaa012beed78914f91926197b1bd2fcd7fc84eaa6bf345367f2860d8cdR30 |
yakimka
force-pushed
the
postgres-driver-override
branch
from
April 2, 2022 15:12
ba94dad to
25af97e
Compare
yakimka
suggested changes
Apr 2, 2022
Co-authored-by: Till Hoffmann <[email protected]>
Contributor
|
@KarolisL, please fix formatting |
yakimka
approved these changes
Apr 4, 2022
This was referenced May 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've found installing
psycopg2driver on MacOS Big Sur being too complicated: I didn't want to installpostgresheaders nor was I able to use the-binaryversion of the package.I've decided to use pure-python driver, but wasn't able to do so due to the driver being hardcoded. This PR addresses the limitation by adding an optional field to the constructor to override the driver.
I've added a
postgresql-pg8000extra preset for convenience, but I'm happy to revert if you find it redundant ( 756f3e1 ).