Repository navigation
Investigate what to do about "localnpipe" on windows #415
Description
it has been some time. the urllib3/docker-py incompatibilities are fixed. the time of using named pipes on windows is here. the question is how to deal with them in this library. for now, i am suggesting a fix like:
class DockerContainer:
# ...
def get_container_host_ip(self) -> str:
# ...
# see https://github.com/testcontainers/testcontainers-python/issues/415
if host == "localnpipe" and "Windows" == system():
return "localhost"
# ...but it really should get investigated in the short term.
Activity
fix at least some tests on windows, see testcontainers#415
#415 fix
#415 fix (#427)
alexanderankin commentedon Mar 8, 2024
#100