Skip to content

Add support for specifying container hostname#889

Merged
cristianrgreco merged 4 commits into
testcontainers:mainfrom
kyzooghost:main
Feb 5, 2025
Merged

Add support for specifying container hostname#889
cristianrgreco merged 4 commits into
testcontainers:mainfrom
kyzooghost:main

Conversation

@kyzooghost

@kyzooghost kyzooghost commented Jan 8, 2025

Copy link
Copy Markdown
Contributor

Address #883

Added TestContainer.withHostname() and StartedTestContainer.getHostname()

@kyzooghost
Feat/hostname (#1)
7d91b74 
* added withHostname

* added getHostname
@netlify

netlify Bot commented Jan 8, 2025 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit d1ded06
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-node/deploys/6792358c3bb11e00084b59c4
😎 Deploy Preview https://deploy-preview-889--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cristianrgreco

cristianrgreco commented Jan 13, 2025

Copy link
Copy Markdown
Collaborator

@kyzooghost Pls add an example to the docs, in containers.md

@cristianrgreco cristianrgreco added enhancement New feature or request minor Backward compatible functionality labels Jan 13, 2025
@cristianrgreco cristianrgreco changed the title [Feat] Added custom container hostname Add support for specifying container hostname Jan 13, 2025
@kyzooghost

kyzooghost commented Jan 15, 2025

Copy link
Copy Markdown
Contributor Author

@kyzooghost Pls add an example to the docs, in containers.md

added with a cautionary note, please check :)

@cristianrgreco

cristianrgreco commented Jan 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@kyzooghost The build is failing.

Probably the AbstractStartedContainer no longer fully implements the StartedTestContainer interface

@kyzooghost

kyzooghost commented Jan 23, 2025

Copy link
Copy Markdown
Contributor Author

@kyzooghost The build is failing.

Probably the AbstractStartedContainer no longer fully implements the StartedTestContainer interface

Will look into it when I can :)

@kyzooghost

kyzooghost commented Jan 23, 2025

Copy link
Copy Markdown
Contributor Author

@cristianrgreco pushed another commit with AbstractStartedContainer.getHostname() method

Ran npm run build -ws on my local and it looks good to me

@kyzooghost

kyzooghost commented Jan 24, 2025

Copy link
Copy Markdown
Contributor Author

@cristianrgreco I see that this one test in the CI failed - https://github.com/testcontainers/testcontainers-node/actions/runs/12929145591/job/36061082486?pr=889

Is this a flaky test 🥲?

@cristianrgreco cristianrgreco merged commit cb89936 into testcontainers:main Feb 5, 2025
@kyzooghost kyzooghost mentioned this pull request Feb 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cristianrgreco cristianrgreco cristianrgreco approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request minor Backward compatible functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kyzooghost @cristianrgreco