Repository navigation
Add support for Colima - #531
Closed
cristianrgreco wants to merge 36 commits into
Closed
cristianrgreco wants to merge 36 commits into
cristianrgreco wants to merge 36 commits into
Conversation
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Closed
|
I've been looking into what it would take to get this working for Java as well, though it sounds like @eddumelendez might take care of that once this is done. Just out of curiosity, is the issue that waiting for log lines just isn't good enough for Colima, and you have to use a port-based wait strategy instead in practice? |
Collaborator
Author
|
Hi @glasser, I've just updated the PR comment with all the info |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR was to integrate support for Colima into testcontainers-node such that we could run the entire test suite with Colima as part of our CICD. As of 19/04/2023 this isn't possible for the following reasons:
2.1. We intermittently see Docker pull rate limits for official images, such as Mongo, PostgreSQL, etc (?!).
2.2. Dockerfiles which install dependencies when built are randomly unable to resolve dependencies, such as curl.
2.3. I have had to increase timeouts of some test suites by a multiplier, so that the tests complete in time.
To re-emphasise, because of the way GH have structured its runners, I cannot rule out that a lot of the issues I've faced are because of the MacOS runners.
This comment is not to say that Colima is unsupported, it means that your mileage may vary. I will soon document some of these issues and workarounds in the official docs, and depending on your use cases and environment, Colima may work without issue.
I will re-visit Colima support in the future. In the meantime if I have missed anything, or someone is able to improve Colima support in testcontainers-node, any contributions are very welcome!