Fix run in container flakiness#489
Merged
Merged
Conversation
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
cristianrgreco
added
bug
cristianrgreco
marked this pull request as ready for review
March 9, 2023 12:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are sometimes seeing test failures related to
run-in-container, used when resolving the default gateway.We currently create the container with
autoRemove: true, attach to it, and wait for the log output. However we see the container is sometimes created and removed so quickly that we cannot inspect it in time, resulting in an error.Now we remove
autoRemove: true, and instead forcefully remove the container once we have consumed all log output. We have also removed some of the interval logic around inspecting the container as this has been fixed apocas/dockerode#534.