Skip to content

Fix Redis container to accept command override#1155

Merged
cristianrgreco merged 3 commits intotestcontainers:mainfrom
ziggornif:main
Nov 11, 2025
Merged

Fix Redis container to accept command override#1155
cristianrgreco merged 3 commits intotestcontainers:mainfrom
ziggornif:main

Conversation

@ziggornif
Copy link
Copy Markdown
Contributor

@ziggornif ziggornif commented Oct 3, 2025

Hi,

Here's a small fix to resolve the Redis container startup issue with custom commands (#1150).

I noticed a similar issue with the redis-stack image that also overrides this.createOpts.Env.
Would you prefer I include this fix in the same PR, or should I create a separate issue to track it first?

@netlify
Copy link
Copy Markdown

netlify bot commented Oct 3, 2025 •
edited
Loading

✅ Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit fd64d0d
🔍 Latest deploy log https://app.netlify.com/projects/testcontainers-node/deploys/69122b7aec86b200082c2816
😎 Deploy Preview https://deploy-preview-1155--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@cristianrgreco
Copy link
Copy Markdown
Collaborator

cristianrgreco commented Oct 6, 2025

Hi @ziggornif, yes please include the redis-stack command change in this PR

@cristianrgreco cristianrgreco added bug Something isn't working patch Backward compatible bug fix labels Oct 6, 2025
@ziggornif
Fix Redis stack container to accept input env vars
3e6fa91 
Same as redis image with input command

See issue #1150
@ziggornif
Copy link
Copy Markdown
Contributor Author

ziggornif commented Oct 6, 2025

Hi @cristianrgreco, I just made the modification for redis-stack as well. The REDIS_ARGS variable now contains the merge of the user's values with the default values.

I kept the current solution of creating the variable via this.withEnvironment which I recreate with the merge of both values.
We could have also edited the existing variable in this.createOpts.Env. If the current solution works for you, I'll leave it as is.

cristianrgreco
cristianrgreco reviewed Nov 4, 2025
View reviewed changes
cristianrgreco
cristianrgreco reviewed Nov 4, 2025
View reviewed changes
@cristianrgreco cristianrgreco added the changes requested PR author must respond to review feedback label Nov 4, 2025
@ziggornif
Copy link
Copy Markdown
Contributor Author

ziggornif commented Nov 10, 2025

@cristianrgreco i remove the split maniplation, use ?? instead of || i kept the solution with withEnvironment as you said.
It's works now by removing previous REDIS_ARGS value before.

I also update tests with await using.

Tell me if these changes correspond to what you wanted

@cristianrgreco cristianrgreco changed the title Fix Redis container to accept input command Fix Redis container to accept command override Nov 11, 2025
@cristianrgreco cristianrgreco removed the changes requested PR author must respond to review feedback label Nov 11, 2025
@cristianrgreco
Copy link
Copy Markdown
Collaborator

cristianrgreco commented Nov 11, 2025

Thanks @ziggornif

@cristianrgreco cristianrgreco merged commit 737f3c2 into testcontainers:main Nov 11, 2025
20 checks passed
vaernion pushed a commit to Arbeidstilsynet/brevgen2 that referenced this pull request Dec 3, 2025
@vaernion
Merged PR 20799: chore(deps): update dependency testcontainers to v11…
bd5a33c 
….9.0

> **Note:** This PR body was truncated due to platform limits.

This PR contains the following updates:

| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [testcontainers](https://github.com/testcontainers/testcontainers-node) | [`11.7.2` -> `11.9.0`](https://renovatebot.com/diffs/npm/testcontainers/11.7.2/11.9.0) | ![age](https://developer.mend.io/api/mc/badges/age/npm/testcontainers/11.9.0?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/testcontainers/11.7.2/11.9.0?slim=true) |

---

### Release Notes

<details>
<summary>testcontainers/testcontainers-node (testcontainers)</summary>

### [`v11.9.0`](https://github.com/testcontainers/testcontainers-node/releases/tag/v11.9.0)

[Compare Source](testcontainers/testcontainers-node@v11.8.1...v11.9.0)

#### Changes

#### 🚀 Features

- Add support for identity token authentication [@&#8203;cristianrgreco](https://github.com/cristianrgreco) ([#&#8203;1179](testcontainers/testcontainers-node#1179))

#### 📦 Dependency Updates

- Bump the dependencies group across 21 directories with 23 updates @&#8203;[dependabot\[bot\]](https://github.com/apps/dependabot) ([#&#8203;1187](testcontainers/testcontainers-node#1187))
- Bump mkdocs-material from 9.6.23 to 9.7.0 in the dependencies group @&#8203;[dependabot\[bot\]](https://github.com/apps/dependabot) ([#&#8203;1186](testcontainers/testcontainers-node#1186))

### [`v11.8.1`](https://github.com/testcontainers/testcontainers-node/releases/tag/v11.8.1)

[Compare Source](testcontainers/testcontainers-node@v11.8.0...v11.8.1)

#### Changes

#### 🐛 Bug Fixes

- Fix Redis container to accept command override [@&#8203;ziggornif](https://github.com/ziggornif) ([#&#8203;1155](testcontainers/testcontainers-node#1155))

#### 📦 Dependency Updates

- Bump the dependencies group with 10 updates @&#8203;[dependabot\[bot\]](https://github.com/apps/dependabot) ([#&#8203;1176](testcontainers/testcontainers-node#1176))
- Bump mkdocs-material from 9.6.22 to 9.6.23 in the dependencies group @&#8203;[dependabot\[bot\]](https://github.com/apps/dependabot) ([#&#8203;1178](testcontainers/testcontainers-node#1178))
- Bump the dependencies group across 28 directories with 31 updates @&#8203;[dependabot\[bot\]](https://github.com/apps/dependabot) ([#&#8203;1177](testcontainers/testcontainers-node#1177))

### [`v11.8.0`](https://github.com/testcontainers/testcontainers-node/releases/tag/v11.8.0)

[Compare Source](testcontainers/testcontainers-node@v11.7.2...v11.8.0)

#### Changes

#### 🚀 Features

- Add configuration for `TESTCONTAINERS_RYUK_RECONNECTION_TIMEOUT` [@&#8203;abendi](https://g...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cristianrgreco cristianrgreco cristianrgreco approved these changes

Assignees

No one assigned

Labels

bug Something isn't working patch Backward compatible bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ziggornif @cristianrgreco