Skip to content

feat(module): support databend#9148

Merged
eddumelendez merged 22 commits intotestcontainers:mainfrom
hantmac:feat/support-databend
Sep 17, 2024
Merged

feat(module): support databend#9148
eddumelendez merged 22 commits intotestcontainers:mainfrom
hantmac:feat/support-databend

Conversation

@hantmac
Copy link
Copy Markdown
Contributor

@hantmac hantmac commented Aug 26, 2024

Hi there, I am a developer from Databend, which is built in Rust, is an open-source cloud data warehouse that serves as a cost-effective warehouse.

This pr add the New Modules: databend

@hantmac hantmac requested a review from a team August 26, 2024 07:27
@hantmac hantmac force-pushed the feat/support-databend branch from 6d20aee to 9e16e8a Compare August 26, 2024 09:47
eddumelendez
eddumelendez requested changes Aug 26, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@eddumelendez eddumelendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hantmac, thanks for your contribution. I have left few comments and please make sure to add modules/databases/databend.md here.

@hantmac hantmac requested a review from eddumelendez August 27, 2024 09:16
eddumelendez
eddumelendez requested changes Aug 27, 2024
View reviewed changes
@hantmac hantmac force-pushed the feat/support-databend branch from cb00c66 to 7340f7a Compare August 28, 2024 02:26
@hantmac hantmac requested a review from eddumelendez August 28, 2024 02:31
eddumelendez
eddumelendez reviewed Aug 29, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@eddumelendez eddumelendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hantmac, the project doesn't compile. Can you please take a look at the comments I left? Also, look at this one too

@hantmac hantmac force-pushed the feat/support-databend branch from 47869ba to f4b94c2 Compare August 30, 2024 03:07
@hantmac hantmac force-pushed the feat/support-databend branch from a16da98 to 5a1e600 Compare August 30, 2024 03:21
@eddumelendez
Copy link
Copy Markdown
Member

eddumelendez commented Sep 3, 2024

Hi @hantmac, the project doesn't compile. PTAL, https://github.com/testcontainers/testcontainers-java/actions/runs/10626268429/job/29586004747?pr=9148#step:5:24

@hantmac
Copy link
Copy Markdown
Contributor Author

hantmac commented Sep 4, 2024

Hi @hantmac, the project doesn't compile. PTAL, https://github.com/testcontainers/testcontainers-java/actions/runs/10626268429/job/29586004747?pr=9148#step:5:24

Thank you very much! I fixed it and have a try again.

@eddumelendez
Copy link
Copy Markdown
Member

eddumelendez commented Sep 4, 2024

still failing, see https://github.com/testcontainers/testcontainers-java/actions/runs/10693866752/job/29645246728?pr=9148

@hantmac can you make sure the project compiles locally?

@hantmac
Copy link
Copy Markdown
Contributor Author

hantmac commented Sep 4, 2024

still failing, see https://github.com/testcontainers/testcontainers-java/actions/runs/10693866752/job/29645246728?pr=9148

@hantmac can you make sure the project compiles locally?

Yeah, it's strange I build it successfully using IDEA.
image

But the code has problems actually.

@hantmac hantmac requested a review from eddumelendez September 9, 2024 05:05
@eddumelendez
Copy link
Copy Markdown
Member

eddumelendez commented Sep 12, 2024

Hi @hantmac, can you please execute ./gradlew spotlessApply

@hantmac
Copy link
Copy Markdown
Contributor Author

hantmac commented Sep 12, 2024

Hi @hantmac, can you please execute ./gradlew spotlessApply

@eddumelendez Hi bro, I have execute ./gradlew :databend:spotlessApply.

@hantmac
Copy link
Copy Markdown
Contributor Author

hantmac commented Sep 15, 2024

@eddumelendez Hi bro, if there has no review comments to be resolved, would you like to merge it?

@eddumelendez eddumelendez merged commit bd0b75f into testcontainers:main Sep 17, 2024
@eddumelendez
Copy link
Copy Markdown
Member

eddumelendez commented Sep 17, 2024

Thanks for your contribution, @hantmac! I have removed the withDatabaseName because there is no env var to allow creating a new database different than default using env vars.

@eddumelendez eddumelendez added this to the next milestone Sep 17, 2024
@hantmac
Copy link
Copy Markdown
Contributor Author

hantmac commented Sep 18, 2024

Thanks for your contribution, @hantmac! I have removed the withDatabaseName because there is no env var to allow creating a new database different than default using env vars.

@eddumelendez Thanks for your help!

fokion pushed a commit to fokion/testcontainers-java that referenced this pull request Jan 18, 2025
@hantmac @fokion
Add module for Databend (testcontainers#9148)
5be5dee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eddumelendez eddumelendez Awaiting requested review from eddumelendez

Assignees

No one assigned

Labels

type/docs type/new module

Projects

None yet

Milestone

1.20.2

Development

Successfully merging this pull request may close these issues.

2 participants

@hantmac @eddumelendez