Merged
Conversation
kiview
reviewed
Aug 22, 2024
|
|
||
| ## Example | ||
|
|
||
| ### Using org.testcontainers.containers.KafkaContainer |
Member
There was a problem hiding this comment.
Shouldn't we replace this documentation sections with org.testcontainers.kafka.KafkaContainer as well? I think accordingly, we can even remove the docs for the deprecated version.
Member
Author
There was a problem hiding this comment.
For those interested in kafka and zookeeper, this could be helpful. Otherwise, it would look like it is not supported.
Comment on lines
+62
to
+65
| !!! note | ||
| Only available for `org.testcontainers.containers.KafkaContainer` | ||
|
|
||
| KRaft mode was declared production ready in 3.3.1 (confluentinc/cp-kafka:7.3.x) |
Member
There was a problem hiding this comment.
Related to above, I think we then can remove docs for the deprecated class.
Co-authored-by: Kevin Wittek <[email protected]>
fokion
pushed a commit
to fokion/testcontainers-java
that referenced
this pull request
Jan 18, 2025
* Deprecate `org.testcontainers.containers.KafkaContainer` * Add `org.testcontainers.kafka.ConfluentKafkaContainer` which works with `confluentinc/cp-kafka` images with version `7.4.0` or later. * `KafkaHelper` container common env vars, command, wait strategy to be shared with `org.testcontainers.kafka.KafkaContainer` --------- Co-authored-by: Kevin Wittek <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
org.testcontainers.containers.KafkaContainerorg.testcontainers.kafka.ConfluentKafkaContainerwhich works withconfluentinc/cp-kafkaimages with version7.4.0or later.KafkaHelpercontainer common env vars, command, wait strategy to be shared withorg.testcontainers.kafka.KafkaContainer