Improve docs for Elasticsearch 8#8870
Conversation
| // }} | ||
| assertThat(response.getStatusLine().getStatusCode()).isEqualTo(200); | ||
| assertThat(EntityUtils.toString(response.getEntity())).contains("cluster_name"); | ||
| // httpClientContainer8 {{ |
There was a problem hiding this comment.
| // httpClientContainer8 {{ | |
| // httpClientContainer8 { |
There was a problem hiding this comment.
In line 211 it is also {{. Which one is correct?
There was a problem hiding this comment.
It should be a single curly brace.
There was a problem hiding this comment.
I tested it and it only works with a single curly brace here. Docs preview looks good to me now
| .build(); | ||
|
|
||
| Response response = client.performRequest(new Request("GET", "/_cluster/health")); | ||
| // }} |
There was a problem hiding this comment.
| // }} | |
| // } |
| // }} | ||
| assertThat(response.getStatusLine().getStatusCode()).isEqualTo(200); | ||
| assertThat(EntityUtils.toString(response.getEntity())).contains("cluster_name"); | ||
| // httpClientContainer8NoSSL {{ |
There was a problem hiding this comment.
| // httpClientContainer8NoSSL {{ | |
| // httpClientContainer8NoSSL { |
|
Hi @philipp94831, thanks for your contribution. I have added some suggestions that will fix how the code is render in the documentation, see https://deploy-preview-8870--testcontainers.netlify.app/modules/elasticsearch/ Also, regarding to the new tests I think |
What is your suggestion wrt duplication? I mainly added the tests in order to document the connection to ES 8. Because of the method used in the existing tests I deemed them unsuitable for documentation purposes |
|
I think if we want to have |
|
Sorry for the delay. Let's proceed with @kiview suggestions. Also, you can check docs locally by running |
|
@philipp94831 can you please run |
|
Thanks @philipp94831 ! |
3 participants
The docs for connecting to Elasticsearch container only work for Elasticsearch v7. For Elasticsearch v8 either the SSLContext has to be configured for the HTTPClient or SSL needs to be disabled. This PR adds according documentation