Skip to content

[docs] Update localstack version#8515

Merged
eddumelendez merged 2 commits intotestcontainers:mainfrom
sullis:sean/localstack-docs-3.3.0
Aug 14, 2024
Merged

[docs] Update localstack version#8515
eddumelendez merged 2 commits intotestcontainers:mainfrom
sullis:sean/localstack-docs-3.3.0

Conversation

@sullis
Copy link
Copy Markdown
Contributor

@sullis sullis commented Apr 7, 2024

@sullis sullis requested a review from a team April 7, 2024 16:08
Copy link
Copy Markdown
Member

@eddumelendez eddumelendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is a good catch, let's improve the docs by adding a code snippet from test's source code.

Comment on lines 9 to 13
```java
DockerImageName localstackImage = DockerImageName.parse("localstack/localstack:0.11.3");
DockerImageName localstackImage = DockerImageName.parse("localstack/localstack:3.3.0");

@Rule
public LocalStackContainer localstack = new LocalStackContainer(localstackImage)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually code snippets are provided from the test source code. Looks like this is not happening for LocalStack docs. Can you update the PR doing so?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sullis do you mind updating the PR?

@eddumelendez eddumelendez added this to the next milestone Aug 14, 2024
@eddumelendez eddumelendez changed the title fix localstack doc [docs] Update localstack version Aug 14, 2024
@eddumelendez eddumelendez merged commit e7f8af5 into testcontainers:main Aug 14, 2024
@eddumelendez
Copy link
Copy Markdown
Member

Thanks for your contribution @sullis !

fokion pushed a commit to fokion/testcontainers-java that referenced this pull request Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants