Skip to content

Log exception on socket problems#8055

Merged
eddumelendez merged 2 commits intotestcontainers:mainfrom
ciis0:patch-1
Oct 22, 2024
Merged

Log exception on socket problems#8055
eddumelendez merged 2 commits intotestcontainers:mainfrom
ciis0:patch-1

Conversation

@ciis0
Copy link
Copy Markdown
Contributor

@ciis0 ciis0 commented Jan 5, 2024

Fixes #8054

Note that SLF4J (1.6.0+) allows the last format parameter to be an exception to be printed https://www.slf4j.org/faq.html#paramException

@ciis0 ciis0 requested a review from a team January 5, 2024 11:18
@eddumelendez eddumelendez added this to the next milestone Oct 22, 2024
@eddumelendez eddumelendez merged commit f50e5c3 into testcontainers:main Oct 22, 2024
@eddumelendez
Copy link
Copy Markdown
Member

Thanks for your contribution, @ciis0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: socket problems should not swallow exceptions

2 participants